Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger OpenTelemetry docs #3727

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

alicejgibbons
Copy link
Contributor

Description

Updates to the Jaeger Dapr docs to support the OpenTelemetry protocol (OTLP) with the Open Telemetry Collector over Zipkin. Jaeger recommends using OTLP and many Zipkin Jaeger clients are being deprecated. New docs do not include the deployment of Jaeger itself as that is well documented on their website in the linked Getting Started guide.

Issue reference

@alicejgibbons alicejgibbons requested review from a team as code owners September 14, 2023 03:55
@alicejgibbons
Copy link
Contributor Author

@msfussell @hhunter-ms fyi!

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review with some formatting (added tabs, one for self-hosted, one for kubernetes)

@github-actions
Copy link

Stale PR, paging all reviewers

alicejgibbons and others added 2 commits September 27, 2023 07:54
Signed-off-by: Alice Gibbons <alice@diagrid.io>
Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Alice Gibbons <alicejgibbons@gmail.com>
Signed-off-by: Alice Gibbons <alice@diagrid.io>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell dismissed hhunter-ms’s stale review September 27, 2023 23:08

Comments addressed

@msfussell msfussell merged commit 9af6270 into dapr:v1.11 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants