-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observability refresh pt 3 #3688
Conversation
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@@ -6,42 +6,48 @@ weight: 900 | |||
description: "How to use Dapr to push trace events through the OpenTelemetry Collector." | |||
--- | |||
|
|||
{{% alert title="Note" color="primary" %}} | |||
Dapr directly writes traces using the OpenTelemetry (OTEL) protocol as the recommended method. For observability tools that support OTEL protocol, you do not need to use the OpenTelemetry Collector. | |||
Dapr directly writes traces using the OpenTelemetry (OTEL) protocol as the **recommended** method. For observability tools that support OTEL protocol, you don't need to use the OpenTelemetry Collector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not actually true (I did this update) and we should change this. The advice here is that you should always run the Open Telemetry collector on your hosting platform and use this to send OTEL events to the observability tool that support OTEL protocol. I suggest that we also include a nice diagram here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msfussell is the current diagram in the doc ok to use, or does that need to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msfussell @hhunter-ms IMO the diagram is still correct but maybe the verbiage could be updated to something like:
"Dapr directly writes traces using the OpenTelemetry (OTEL) protocol as the recommended method. For observability tools that support OTEL protocol, it is still recommended to use the OpenTelemetry Collector since it allows your app to offload data quickly and includes other features like retries, batching and encryption. For more information, read the Open Telemetry documentation."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @alicejgibbons! I updated the doc with your revised intro
daprdocs/content/en/operations/observability/tracing/otel-collector/open-telemetry-collector.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/observability/tracing/otel-collector/open-telemetry-collector.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/observability/tracing/tracing-overview.md
Show resolved
Hide resolved
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Stale PR, paging all reviewers |
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
daprdocs/content/en/operations/observability/tracing/otel-collector/open-telemetry-collector.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ector/open-telemetry-collector.md Signed-off-by: Mark Fussell <markfussell@gmail.com>
Description
OTEL collector review/pass
TOC update
Issue reference
PR will close: #3668