Define common metadata across components #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
|
Complete certification test run: https://github.com/dapr/components-contrib/actions/runs/2906632656 |
Codecov Report
@@ Coverage Diff @@
## master #1994 +/- ##
=======================================
Coverage 37.66% 37.66%
=======================================
Files 192 192
Lines 23982 23982
=======================================
Hits 9032 9032
Misses 14183 14183
Partials 767 767
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
berndverst
requested changes
Aug 22, 2022
There was a problem hiding this comment.
This PR is breaking certification tests.
Please update the tests in tests/certification
Example
Error: /home/runner/go/pkg/mod/github.com/dapr/dapr@v1.8.0-rc.1.0.20220713223752-9c6ab20ec023/pkg/runtime/runtime.go:520:25: unknown field 'Properties' in struct literal of type middleware.Metadata
Error: /home/runner/go/pkg/mod/github.com/dapr/dapr@v1.8.0-rc.1.0.20220713223752-9c6ab20ec023/pkg/runtime/runtime.go:1255:3: unknown field 'Properties' in struct literal of type "github.com/dapr/components-contrib/bindings".Metadata
Error: /home/runner/go/pkg/mod/github.com/dapr/dapr@v1.8.0-rc.1.0.202207132237[52](https://github.com/dapr/components-contrib/runs/7959860290?check_suite_focus=true#step:14:53)-9c6ab20ec023/pkg/runtime/runtime.go:1256:3: unknown field 'Name' in struct literal of type "github.com/dapr/components-contrib/bindings".Metadata
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
mcandeia
force-pushed
the
feat/common-components-metadata
branch
from
b8654b9 to
58c984d
Compare
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
berndverst
previously approved these changes
Aug 23, 2022
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
berndverst
previously approved these changes
Aug 24, 2022
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
berndverst
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcos Candeia marrcooos@gmail.com
Description
This PR adds a common and shared metadata across components. Notice that the json-serialization and way to get properties haven't changed.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1990
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: