Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): add support for setting localStorage before navigation #579

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Jul 3, 2023

This was necessary so e2e tests could run due to the new Nav update, as nav is hidden by default.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration:

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@danny-avila danny-avila merged commit 10c772c into main Jul 3, 2023
@danny-avila danny-avila deleted the fix-e2e-nav branch July 3, 2023 20:37
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant