Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 feat: Enhance Assistant Model Handling for Model Specs #4390

Merged
merged 3 commits into from
Oct 11, 2024
Merged

🤖 feat: Enhance Assistant Model Handling for Model Specs #4390

merged 3 commits into from
Oct 11, 2024

Conversation

danny-avila
Copy link
Owner

Summary

  • Added logic in ModelSpecsMenu and useSelectMention to set the model for assistants when an assistant_id is present but no model is specified by the model spec.
  • Updated useNewConvo hook to use the Constants.NEW_CONVO instead of hardcoded 'new' string for better maintainability.
  • Modified updateLastSelectedModel function in endpoints.ts to handle empty string values and improve JSON parsing robustness.

@danny-avila danny-avila merged commit bab0152 into main Oct 11, 2024
2 checks passed
@danny-avila danny-avila deleted the refactor/asst-model-specs branch October 11, 2024 12:20
owengo pushed a commit to openwengo/LibreChat that referenced this pull request Oct 14, 2024
@danny-avila @olivierhub
🤖 feat: Enhance Assistant Model Handling for Model Specs (danny-avila…
4d57369 
…#4390)

* chore: cleanup type issues in client/src/utils/endpoints

* refactor: use Constant enum for 'new' conversationId

* refactor: select assistant model if not provided for model spec
danny-avila added a commit that referenced this pull request Oct 27, 2024
@danny-avila
🤖 feat: Enhance Assistant Model Handling for Model Specs (#4390)
cb8ecfb 
* chore: cleanup type issues in client/src/utils/endpoints

* refactor: use Constant enum for 'new' conversationId

* refactor: select assistant model if not provided for model spec
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
@danny-avila
🤖 feat: Enhance Assistant Model Handling for Model Specs (danny-avila…
0f03d48 
…#4390)

* chore: cleanup type issues in client/src/utils/endpoints

* refactor: use Constant enum for 'new' conversationId

* refactor: select assistant model if not provided for model spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danny-avila