🔨 fix(AzureOpenAI): o1 model, stream parameter check
#4381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s before deletion
1 task
danny-avila
changed the title
stream parameter check
danny-avila
approved these changes
Oct 10, 2024
|
lgtm, ty |
owengo
pushed a commit
to openwengo/LibreChat
that referenced
this pull request
Oct 14, 2024
danny-avila
pushed a commit
that referenced
this pull request
Oct 27, 2024
BertKiv
pushed a commit
to BertKiv/LibreChat
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the
modelOptions.modelparam for o1 models using Azure OpenAI client was being deleted before the stream compatibility check. As a result, thestreamparameter was not properly validated for these models, leading to errors. The fix ensures that the model check for o1 models of azure clients is checked before deletion to resolve the unsupported parameter issue.Closes #4379
Change Type
Please delete any irrelevant options.
Testing
Performed
docker buildwith this change and tested it manually to ensure the o1 models using Azure OpenAI clients now pass validation properly.Checklist
Please delete any irrelevant options.