Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 fix: Resolve Unarchive Conversation Bug, Archive Pagination #4189

Merged
merged 7 commits into from
Sep 22, 2024

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Sep 22, 2024

Summary

Closes #4188

  • Fixed a bug causing unarchived conversations to revert to archived state and create blank "New Chat" entries.
  • Implemented a cleanup service to delete conversations with null or empty conversationIds on app startup.
  • Refactored the ArchivedChatsTable component to use the new useArchiveConvo hook for better state management.
  • Added proper typing and improved styling in the ArchivedChatsTable component.
  • Created a new useArchiveConvo hook to handle archiving and unarchiving conversations with proper error handling and notifications.
  • Updated the useArchiveConvoMutation to properly handle the isArchived state and update the relevant queries.
  • Fixed Archive Pagination

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules

@danny-avila danny-avila merged commit 4328a25 into main Sep 22, 2024
4 checks passed
@danny-avila danny-avila deleted the fix/cleanup-archive-convos branch September 22, 2024 21:21
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
…avila#4189)

* feat: add cleanup service for 'bugged' conversations (empty/nullish conversationIds)

* fix(ArchivedChatsTable): typing and minor styling issues

* fix: properly archive conversations

* fix: archive convo application crash

* chore: remove unused `useEffect`

* fix: add basic navigation

* chore: typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unarchiving a chat requires 2 attempts and creates a blank chat
1 participant