🛠️ fix(ldap): LDAP_LOGIN_USES_USERNAME config
#3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny-avila
approved these changes
Jul 29, 2024
danny-avila
changed the title
LDAP_LOGIN_USES_USERNAME config
danny-avila
pushed a commit
that referenced
this pull request
Aug 5, 2024
danny-avila
pushed a commit
that referenced
this pull request
Aug 17, 2024
kenshinsamue
pushed a commit
to intelequia/LibreChat
that referenced
this pull request
Sep 17, 2024
BertKiv
pushed a commit
to BertKiv/LibreChat
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with the LDAP login configuration where the system was not switching to username input when the
LDAP_LOGIN_USES_USERNAMEenvironment variable was set to true. The problem was caused by a missing return statement in thegetLdapConfigfunction inldap.js. This change ensures that the LDAP configuration is correctly returned when username login is enabled, allowing users to log in with their username as intended.This PR resolves issue #3471.
Change Type
Testing
To test this change:
LDAP_LOGIN_USES_USERNAME=truein the .env fileTest Configuration:
LDAP_LOGIN_USES_USERNAMEset to true in .env fileChecklist