-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto-scroll to the bottom of the conversation #1049
Conversation
@danny-avila, I'm not sure, but I believe the issue "when you open a conversation with images, the conversation scrolls afterward" can only be fixed by doing something like in #910. |
what do you mean by this? |
I mean that when you open a conversation with images generated by stable diffusion or dall-e, first it load the images and then scroll down |
so the auto scroll you made doesn't happen in this case? |
For context, got a reply on discord:
|
d57fb79
to
bf7b6c5
Compare
* added button for autoscroll * fix(General) removed bold * fix(General) typescript error with checked={autoScroll} * added return condition for new conversations * refactor(Message) limit nesting * fix(settings) used effects * fix(Message) disabled autoscroll when search * test(AutoScrollSwitch) * fix(AutoScrollSwitch) test * fix(ci): attempt to debug workflow * refactor: move AutoScrollSwitch from General file, don't use cache for npm * fix(ci): add test config to avoid redirects and silentRefresh * chore: add back workflow caching * chore(AutoScrollSwitch): remove comments, fix type issues, clarify switch intent * refactor(Message): remove unnecessary message prop form scrolling condition * fix(AutoScrollSwitch.spec): do not get by text --------- Co-authored-by: Danny Avila <messagedaniel@protonmail.com>
* added button for autoscroll * fix(General) removed bold * fix(General) typescript error with checked={autoScroll} * added return condition for new conversations * refactor(Message) limit nesting * fix(settings) used effects * fix(Message) disabled autoscroll when search * test(AutoScrollSwitch) * fix(AutoScrollSwitch) test * fix(ci): attempt to debug workflow * refactor: move AutoScrollSwitch from General file, don't use cache for npm * fix(ci): add test config to avoid redirects and silentRefresh * chore: add back workflow caching * chore(AutoScrollSwitch): remove comments, fix type issues, clarify switch intent * refactor(Message): remove unnecessary message prop form scrolling condition * fix(AutoScrollSwitch.spec): do not get by text --------- Co-authored-by: Danny Avila <messagedaniel@protonmail.com>
added a switch to enable and disable "auto-scroll to bottom of conversation when opening"
on
off
issue:
- [ ] when you open a conversation with images, the conversation scrolls afterwardChange Type
Testing
Check if the button works on different browser and with npm or docker.
Check if after refreshing the page it works
Checklist