Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(balance/models): request only when authenticated, modelsQuery "optimistic" update #1031

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

danny-avila
Copy link
Owner

Summary

Fixes the 401 errors for api/models and api/balance
Also changed Eng text from 'New chat' to 'New Chat' to match official.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

Manual testing

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila changed the title fix(balance/models): request only when authenticated, modelsQuery optimistic update fix(balance/models): request only when authenticated, modelsQuery "optimistic" update Oct 9, 2023
@danny-avila danny-avila merged commit b3aac97 into main Oct 9, 2023
2 checks passed
@danny-avila danny-avila deleted the query-fix branch October 9, 2023 19:10
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
…timistic" update (danny-avila#1031)

* fix(balanceQuery/modelsQuery): request only when authenticated

* style: match new chat capitalization to official

* fix(modelsQuery): update selected model optimistically

* ci: update e2e changes, disable title in ci env

* fix(ci): get new chat button by data-testid and not text
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
…timistic" update (danny-avila#1031)

* fix(balanceQuery/modelsQuery): request only when authenticated

* style: match new chat capitalization to official

* fix(modelsQuery): update selected model optimistically

* ci: update e2e changes, disable title in ci env

* fix(ci): get new chat button by data-testid and not text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant