Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localization): add Korean language support #1005

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

ywkim
Copy link
Contributor

@ywkim ywkim commented Sep 26, 2023

Summary

This PR adds support for the Korean language in the application. The changes include adding Korean as an option in the language selector, importing the Korean translation file, and adding translated phrases in Korean.

Change Type

  • New feature (non-breaking change which adds functionality)

Testing

The changes were visually inspected and manually tested to ensure that the Korean language option appears in the language selector and that the application displays the correct translations when Korean is selected.

Test Configuration:

  • Language: Korean

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila
Copy link
Owner

@berry-13 I know there was some recent changes to adding new languages, does this look good to you?

Copy link
Collaborator

@berry-13 berry-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@berry-13 I know there was some recent changes to adding new languages, does this look good to you?

@danny-avila Looks good to me

@danny-avila danny-avila merged commit 6c16e91 into danny-avila:main Sep 26, 2023
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
* feat(localization): add Korean language support

* feat(Nav): add Korean language option to General Settings (#20)

* feat(localization): add Korean language support

* refactor(localization): remove unused translations in Korean language file

* feat(localization): update Korean translations

* refactor(localization): update Korean translations in Ko.tsx
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
* feat(localization): add Korean language support

* feat(Nav): add Korean language option to General Settings (danny-avila#20)

* feat(localization): add Korean language support

* refactor(localization): remove unused translations in Korean language file

* feat(localization): update Korean translations

* refactor(localization): update Korean translations in Ko.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants