Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I ran into an issue with the stroke widths produced by the tool. The exported SVG paths had the
vector-effect="non-scaling-stroke"
attribute set on them.Inkscape supports this for rendering, but does not expose the setting in its UI. This has the effect of producing surprisingly inconsistent stroke widths on display an export. For example, the stroke width relative to the drawing varies when the zoom level changes (see screenshots below).
Non-scaling strokes are the default in Maker.js. I assume this is because it makes sense for plotters. But for digital use, I could really use a setting that lets me remove that non-scaling-stroke attribute.
This PR allows the user to control the stroke scaling through a "Non-scaling Stroke" checkbox. The default setting of
true
is preserved to avoid a breaking change, although it might make sense to make the defaultfalse
instead, depending on the primary use case for this tool.Here's some example output as seen in Inkscape. The first line, "Scaling stroke", is what this PR makes possible. The second line, "Non-scaling stroke", is what the tool produces today.
Thanks for publishing this tool by the way, it's super handy!