Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified the UI , added a download button and Copy Button #16

Merged
merged 9 commits into from
May 19, 2021
Merged

Modified the UI , added a download button and Copy Button #16

merged 9 commits into from
May 19, 2021

Conversation

Lucky-victory
Copy link
Contributor

Modified the User Interface, added copy to clipboard button , also the ability to download the svg as a .svg file.

@danmarshall
Copy link
Owner

Hi @Lucky-victory , thanks a lot! Can you add a screenshot of what it looks like, to save me some time?

@Lucky-victory
Copy link
Contributor Author

Alright, here's the screenshot
Screenshot_20210516-175328_1

@danmarshall
Copy link
Owner

Thanks! Now there is one other issue - the index.js file id generated from the Typescript file index.ts. Can you make your changes in the .ts file?

@Lucky-victory
Copy link
Contributor Author

Sure, let me fix that

@Lucky-victory
Copy link
Contributor Author

done

@danmarshall
Copy link
Owner

Can we leave the <h1>Google font to SVG path</h1> as text? I'd like to keep it SEO friendly.

@Lucky-victory
Copy link
Contributor Author

that's right.

@Lucky-victory
Copy link
Contributor Author

done

@danmarshall
Copy link
Owner

Thanks!

@danmarshall danmarshall merged commit 7f6c9ca into danmarshall:master May 19, 2021
@Lucky-victory Lucky-victory deleted the Modify_the_UI branch May 20, 2021 07:29
@Lucky-victory Lucky-victory restored the Modify_the_UI branch May 20, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucky-victory @danmarshall