Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate pyflakes rules in ruff #928

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Activate pyflakes rules in ruff #928

merged 7 commits into from
Oct 25, 2023

Conversation

zariiii9003
Copy link
Contributor

@danielhrisca I added a few rules to "ignore", could you take a look at those and push fixes to this PR?

  • "F821", # undefined-name:

    • 5 occurrences, these are obvious bugs which must be fixed

  • "F401", # unused-import

    • 15 occurrences, ruff suggests to consider importlib.util.find_spec to test for availability

  • "F841", # unused-variable

    • 53 occurrences, these could just be removed, but maybe you left them for informational purposes. These could be fixed with a _ prefix

@danielhrisca
Copy link
Owner

how can I run ruff to see the warnings?

@zariiii9003
Copy link
Contributor Author

how can I run ruff to see the warnings?

ruff check ./src

But you have to comment out the ignored rules in pyproject.toml to see the warnings.

@zariiii9003
Copy link
Contributor Author

@danielhrisca Can you merge this? I'll fix the other stuff in a separate PR. This one contains no logic changes.

@danielhrisca
Copy link
Owner

Thanks

@danielhrisca danielhrisca merged commit 6f540ba into danielhrisca:development Oct 25, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zariiii9003 @danielhrisca