Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions generated from incorrectly filling in the arguments of an endpoint are not escalated to the custom exceptions handler. #356

Closed
diegofgeremias opened this issue Apr 7, 2020 · 0 comments
Assignees
Labels
accepted Issue has been accepted and inserted in a future milestone
Milestone

Comments

@diegofgeremias
Copy link

When I invoke a method from my API filling an erroneous argument, for example, the method expects an integer argument and I fill a string argument, an exception is generated as expected, but this exception is not escaleted to the custom exceptions handler that I defined in the 'SetExceptionHandler' method.

Wouldn't it be interesting that this type of exception was also 'escalated' to the personalized management of exceptions?

Example of method call to simulate the situation:

//Correct invoke
GET http://localhost:8080/api/v1/users/1

//Invoke that causes the error
GET http://localhost:8080/api/v1/users/a

As far as I could tell, the call to the 'FillActualParamsForAction' method of the 'TMVCEngine' class is surrounded by a try except, when in fact, it shouldn't.

@diegofgeremias diegofgeremias changed the title Exceptions generated from incorrectly filling in the arguments of an endpoint are not escalated when handling custom exceptions. Exceptions generated from incorrectly filling in the arguments of an endpoint are not escalated to the custom exceptions handler. Apr 7, 2020
@danieleteti danieleteti added this to the 3.2.0-boron milestone Apr 8, 2020
@danieleteti danieleteti added the accepted Issue has been accepted and inserted in a future milestone label Apr 8, 2020
@danieleteti danieleteti self-assigned this Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issue has been accepted and inserted in a future milestone
Projects
None yet
Development

No branches or pull requests

2 participants