-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Swift 5.5 and Xcode 13 #480
Conversation
Update upstream
Since it's no longer needed for Swift 5.5
Seems super strange |
I believe is because of 8ae3636 |
@f-meloni didn't seem to fix it 🤔 |
@AvdLee that commit is still in your branch, you will probably have to make an interactive rebase :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
500 commits for a 4 word change ;) - I've been there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
I will make few other tests just to be sure everything works as expected, even if the CI passing is already a really good sign, and merge it.
Can you please update the changelog if you don't mind?
There's a Danger rule for that, did you know? 😜 I'll add it now at least! |
To be fair I can test it in master as well, no reason to hold this PR |
I think we are linking the changelog on Twitter when we make a release (which automatically adds the new version to the changelog blow the |
I've tried to do a make install (after I deleted the previous files in
because there is no library to copy in the .build. |
I've reproduced the issue here https://github.com/danger/swift/runs/4055493568?check_suite_focus=true and added a CI suite that can reproduce the issue |
@f-meloni is there a middle ground you think that fixes the Xcode 13 bug ánd doesn't break old systems? |
@AvdLee I would love to find something like a parameter that I can pass to swift build to force it to build Danger as dynamic without having to specify it on SPM. |
If it's only failing for that script, it would make total sense. It would be weird to me to not support SPM which is heavily used in Danger environments, so we need to get to a working solution. This sounds like the way to go to me! |
The
dynamic
type is no longer needed and actually breaks running tests for Danger plugins with Xcode 13.The error that's fixed with this PR:
Fixes #475