Fix for inline empty Dictionary: Bitbucket Cloud #280
Conversation
khoogheem
changed the title
Sources/Danger/BitBucketCloud.swift
Outdated
| self.deleted = try container.decode(Bool.self, forKey: .deleted) | ||
| self.id = try container.decode(Int.self, forKey: .id) | ||
| // protect from "inline": {} | ||
| self.inline = (try? container.decodeIfPresent(Inline.self, forKey: .inline)) ?? nil |
There was a problem hiding this comment.
You can just make path optional too, and that prevents from "inline": {} as well, but also from all the combinations that you can have (only path, only from etc).
If, on the other hand, it either have only zero or all the variables, I would then make them all required, and keep this line, what are your thoughts about this?
There was a problem hiding this comment.
Clearly from the json I printed out.. to was set to null. so I don't think you can make them all required.
Decoding JSON is like a losing battle if you don't control it ;)
There was a problem hiding this comment.
I would be ok I guess with having everything in inline be optional
There was a problem hiding this comment.
ok.. so we rather just make all of the fields in inline optional vs the init right?
|
Remember also to update the changelog with the change, the link to this PR and to your account :) |
This fixes the issue where the json payload for the Comment can have inline as an empty dictionary:
vs