Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing location query param #1069

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Handle missing location query param #1069

merged 1 commit into from
Apr 27, 2022

Conversation

jjnesbitt
Copy link
Member

Closes #1058

@jjnesbitt jjnesbitt requested a review from mvandenburgh April 26, 2022 20:25
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjnesbitt
Copy link
Member Author

This page doesn't render any files with these changes - deploy-preview-1069--gui-staging-dandiarchive-org.netlify.app/dandiset/000018/draft/files?location=

(the same page on the staging gui instance does work)

Yeah my bad, I'm fixing that up now.

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjnesbitt jjnesbitt merged commit 8c4be8e into master Apr 27, 2022
@jjnesbitt jjnesbitt deleted the 1058-file-browser branch April 27, 2022 15:57
@dandibot
Copy link
Member

🚀 PR was released in v0.2.18 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/files - no progress, no files TypeError: Cannot read properties of undefined (reading 'toString')
3 participants