Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create cache key for pnpm lock file #1894

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Conversation

rebelchris
Copy link
Contributor

Changes

Describe what this PR does

  • Make cache dependant on pnpm lock file

Events

Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet

Log the new/changed events below:

Type event_name value
Change/New event name extra: { ... }

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

WT-{number} #done

.circleci/config.yml Outdated Show resolved Hide resolved
@rebelchris rebelchris merged commit c4bbb2a into main Jun 21, 2023
@rebelchris rebelchris deleted the fix-pnpm-cache-circleci branch June 21, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants