-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to node 16 #1050
chore: update to node 16 #1050
Conversation
@KyleTryon I forgot to put it back in one commit, should be re-added now. |
I have tested again with the latest code in your branch, and I am not able to install it locally. Have you fully deleted your node_modules folder locally before re-installing?
I have found several examples of similar issues reported with lerna but none that I have seen yet offer much for solutions. Do we know, is this package meant to be in the registry? Is lerna supposed to be using the local packages rather than attempting to fetch them remotely? |
Before releasing it's crucial we do extended tests locally for all three compartments. Also sidenote to update the docs and install steps. |
Gitpod perhaps as well |
…upgrade � Conflicts: � packages/extension/package-lock.json
@sshanzel @kirillkurko would love to also get your review on this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing! Thank you for the effort in pushing to v16!!! 🚢
Just had one question regarding a commented out test case.
…upgrade � Conflicts: � packages/extension/package-lock.json
…upgrade � Conflicts: � packages/extension/package-lock.json
Changes
Describe what this PR does
Please make sure existing components are not breaking/affected by this PR
Manual Testing
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
DD-{number} #done