Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to node 16 #1050

Merged
merged 29 commits into from
Jul 7, 2022
Merged

chore: update to node 16 #1050

merged 29 commits into from
Jul 7, 2022

Conversation

rebelchris
Copy link
Contributor

Changes

Describe what this PR does

  • Upgraded to Node 16

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

DD-{number} #done

@KyleTryon
Copy link

Hey folks, i tried this out locally and noticed that I am getting the NPM install error there as well.

image

Looks like we are looking for @dailydotdev/eslint-config externally though I see it is bundled in as a lerna package.

@rebelchris
Copy link
Contributor Author

@KyleTryon I forgot to put it back in one commit, should be re-added now.
The main change of this PR is switching from Node 14 to 16, it seems to create some peer dependency issue, but for some reason I can install everything locally.

@KyleTryon
Copy link

@KyleTryon I forgot to put it back in one commit, should be re-added now. The main change of this PR is switching from Node 14 to 16, it seems to create some peer dependency issue, but for some reason I can install everything locally.

I have tested again with the latest code in your branch, and I am not able to install it locally. Have you fully deleted your node_modules folder locally before re-installing?

image

npm ERR! 404 Not Found - GET https://registry.npmjs.org/@dailydotdev%2feslint-plugin-daily-dev-eslint-rules - Not found
npm ERR! 404 
npm ERR! 404  '@dailydotdev/eslint-plugin-daily-dev-eslint-rules@*' is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)

I have found several examples of similar issues reported with lerna but none that I have seen yet offer much for solutions.

Do we know, is this package meant to be in the registry? Is lerna supposed to be using the local packages rather than attempting to fetch them remotely?

@rebelchris
Copy link
Contributor Author

Before releasing it's crucial we do extended tests locally for all three compartments.
webapp - extension and companion.

Also sidenote to update the docs and install steps.

@idoshamun
Copy link
Member

Gitpod perhaps as well

…upgrade

� Conflicts:
�	packages/extension/package-lock.json
@rebelchris rebelchris marked this pull request as ready for review July 6, 2022 11:24
@rebelchris
Copy link
Contributor Author

@sshanzel @kirillkurko would love to also get your review on this one

Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Thank you for the effort in pushing to v16!!! 🚢

Just had one question regarding a commented out test case.

packages/shared/src/components/sidebar/Sidebar.spec.tsx Outdated Show resolved Hide resolved
…upgrade

� Conflicts:
�	packages/extension/package-lock.json
@rebelchris rebelchris merged commit 50a45fc into master Jul 7, 2022
@rebelchris rebelchris deleted the chore-node-upgrade branch July 7, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants