Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use hoisted mode for e2e test #920

Closed
wants to merge 1 commit into from

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Sep 30, 2024

hoisted mode will make e2e test has same node_modules sturcture with npm

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2024 2:05pm

Copy link

codesandbox-ci bot commented Sep 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor Author

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like file id for RSC part is invalid on windows?

@himself65 himself65 marked this pull request as draft September 30, 2024 02:36
@himself65 himself65 force-pushed the himself65/20240929/linker branch from 67ed830 to d49e5e3 Compare October 5, 2024 07:00
@himself65 himself65 force-pushed the himself65/20240929/linker branch from d49e5e3 to 397acbe Compare December 28, 2024 14:05
@himself65 himself65 marked this pull request as ready for review December 28, 2024 14:18
@himself65
Copy link
Contributor Author

#1087 this PR refactor the install step using npm so hoisted mode will doesn't matter now I think

@himself65 himself65 marked this pull request as draft December 28, 2024 14:23
@himself65 himself65 marked this pull request as ready for review December 28, 2024 14:23
@himself65 himself65 marked this pull request as draft December 28, 2024 14:27
@dai-shi dai-shi closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants