Adopt type=module #208
Merged
Adopt type=module #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow changes in d3-format: * type=module * add exports * remove zip * license: ISC * update dependencies
|
I rewrote the d3-geo snapshot tests to use pixelmatch, and it seems to work well: Do you want to take a crack at updating this PR to match? (And adding the .github/eslint.json, updating the rollup.config.js to extract the copyright from the LICENSE, upgrading the dependencies, using named imports in the tests, etc.) The biggest question in my mind right now is how the CLI will work in a pure ES modules environment, given that geoproject currently takes a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow changes in d3-format:
TODO: