Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: system test tooling improvements #20966

Merged
merged 5 commits into from
Apr 7, 2022
Merged

chore: system test tooling improvements #20966

merged 5 commits into from
Apr 7, 2022

Conversation

tgriesser
Copy link
Member

  • Closes N/A

User facing changelog

N/A

Additional details

  • Improves the system test tooling by allowing importing from @tooling/system-tests directly to get the Fixtures API.
  • Moves the codegenerated fixturesDir into a sibling of the fixtures API file & gitignores it

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 7, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 7, 2022 •
edited
Loading


Test summary

17830 • 0 • 217 • 0 • Flakiness 0

Run details
Project cypress
Status Passed
Commit 87aa128
Started Apr 7, 2022 5:37 PM
Ended Apr 7, 2022 5:50 PM
Duration 12:01 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

tgriesser added 2 commits April 7, 2022 13:30
@tgriesser
browser export path for fixture dirs
1cd3d57
@tgriesser
Merge branch '10.0-release' into tgriesser/feat/fixture-tooling-impro…
87aa128 
…vements

* 10.0-release:
  feat: add new vite-dev-server package based on object API & bundling (#20925)
@tgriesser tgriesser marked this pull request as ready for review April 7, 2022 18:35
@tgriesser tgriesser requested review from a team as code owners April 7, 2022 18:35
@tgriesser tgriesser requested review from jennifer-shehane, flotwig, ZachJW34, BlueWinds and a team and removed request for a team, ZachJW34 and BlueWinds April 7, 2022 18:36
@tgriesser tgriesser requested a review from estrada9166 April 7, 2022 19:08
@tgriesser tgriesser merged commit 4a9d683 into 10.0-release Apr 7, 2022
@tgriesser tgriesser deleted the tgriesser/feat/fixture-tooling-improvements branch April 7, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estrada9166 estrada9166 estrada9166 approved these changes

@flotwig flotwig flotwig approved these changes

@jennifer-shehane jennifer-shehane Awaiting requested review from jennifer-shehane jennifer-shehane was automatically assigned from cypress-io/end-to-end

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgriesser @flotwig @estrada9166