Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use graphql eslint rules #18832

Merged
merged 5 commits into from
Nov 9, 2021
Merged

feat: Use graphql eslint rules #18832

merged 5 commits into from
Nov 9, 2021

Conversation

estrada9166
Copy link
Member

@estrada9166 estrada9166 commented Nov 9, 2021 •
edited
Loading

User facing changelog

Additional details

Use eslint-plugin-graphql to ensure we are querying the id when available, to make the cache consistent.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@estrada9166 estrada9166 requested a review from a team as a code owner November 9, 2021 03:05
@estrada9166 estrada9166 requested review from jennifer-shehane and removed request for a team November 9, 2021 03:05
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 9, 2021

Thanks for taking the time to open a PR!

@estrada9166 estrada9166 changed the title Use graphql eslint rules feat: Use graphql eslint rules Nov 9, 2021
tgriesser
tgriesser approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@tgriesser tgriesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cypress
Copy link

cypress bot commented Nov 9, 2021 •
edited
Loading


Test summary

5266 • 1 • 58 • 2 • Flakiness 3

Run details
Project cypress
Status Failed
Commit 9802fb7
Started Nov 9, 2021 4:27 AM
Ended Nov 9, 2021 4:38 AM
Duration 11:14 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️

Failures

cypress/integration/cypress/proxy-logging-spec.ts 1 Failed
1 Proxy Logging > request logging > xhr log has response body/status code

Flakiness

commands/net_stubbing_spec.ts 2 Flakiness
1 network stubbing > intercepting request > can modify the request body
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
cypress/proxy-logging-spec.ts 1 Flakiness
1 ... > works with forceNetworkError

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tgriesser tgriesser merged commit 8add3b5 into unified-desktop-gui Nov 9, 2021
@tgriesser tgriesser deleted the alejandro/unified-desktop/use-eslint-for-graphql branch November 9, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgriesser tgriesser tgriesser approved these changes

@jennifer-shehane jennifer-shehane Awaiting requested review from jennifer-shehane jennifer-shehane was automatically assigned from cypress-io/end-to-end

@lmiller1990 lmiller1990 Awaiting requested review from lmiller1990

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estrada9166 @tgriesser