Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add graphql to unified-desktop branch #17305

Merged

Conversation

tgriesser
Copy link
Member

Begins the process of adding graphql to the unified-desktop-gui branch:

Adds:

  • yarn dev:watch from the root for a server that restarts when GraphQL code is updated
  • GraphQL Code Generator yarn codegen --watch from the launchpad app
  • IPC link for executing GraphQL

Todo:

  • Add testing integration / tooling
  • Codegen Vue prop types for fragments
  • Hook GraphQL codegen so it runs alongside vite with yarn watch

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 13, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 13, 2021



Test summary

18159 0 214 7Flakiness 4


Run details

Project cypress
Status Passed
Commit 7dc75a7
Started Jul 20, 2021 1:46 PM
Ended Jul 20, 2021 1:57 PM
Duration 11:31 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
3 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
4 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 self-requested a review July 19, 2021 07:52
@lmiller1990
Copy link
Contributor

lmiller1990 commented Jul 19, 2021

@tgriesser I will pick this up and get it green so we can merge it into unified-desktop-gui. Let me know if there was anything else you wanted to work on. I think this is in a good enough place to merge up (into the feature branch).

@tgriesser
Copy link
Member Author

@lmiller1990 I had been starting to work on getting this so we can mount "fragments" for testing: 21206bd and adding SDL definition directives to Nexus so that we can specify what the "test values" should be in the server definition in a way that the frontend schema can consume.

Unfortunately the timing on this work hasn't mapped well to my PTO this week and last.

So feel free to pick it up from here for now - also was having trouble seeing how Vue validates props, either with the props definition or in the fragment use. Seemed it was very easy to use invalid values in the template without any sort of type or runtime errors/warning.

@lmiller1990
Copy link
Contributor

lmiller1990 commented Jul 19, 2021

@tgriesser nice to see the test scaffolding. I'll get this back to ✅ , always good to keep things passing before it goes too out of sync.

As for Vue, I've found you can use PropType and a VS Code extension called Volar to get template validation in your IDE. I am sure there's some way to tweak tsconfig.json to error out when there are invalid types during the build step, too.

The prop validator key is most useful for when working with JS - similar to propTypes in React. I am not sure it will be too useful here, but it's possible to throw an error inside it if you want to be really defensive.

@lmiller1990 lmiller1990 marked this pull request as ready for review July 20, 2021 13:43
@lmiller1990 lmiller1990 requested a review from a team as a code owner July 20, 2021 13:43
@lmiller1990 lmiller1990 requested review from flotwig and kuceb and removed request for a team July 20, 2021 13:43
@lmiller1990 lmiller1990 merged commit 1550733 into unified-desktop-gui Jul 20, 2021
@tgriesser tgriesser deleted the tgriesser/unified-desktop-gui/add-graphql branch September 29, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants