redo {spmatrix,matrix}iter_tp to use PyType_Ready #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you accept a PR to add PyPy to your CI matrix? |
mattip
commented
Apr 16, 2020
| @@ -2006,7 +2008,7 @@ PyMODINIT_FUNC initbase(void) | |||
| if (PyType_Ready(&matrix_tp) < 0) | |||
| INITERROR; | |||
|
|
|||
| if (PyType_Ready(&matrix_tp) < 0) | |||
| if (PyType_Ready(&matrixiter_tp) < 0) | |||
There was a problem hiding this comment.
possible typo? Maybe the intent was to do this all along?
mattip
commented
Apr 16, 2020
| @@ -2150,9 +2150,6 @@ matrix_iter(matrix *obj) | |||
| it = PyObject_GC_New(matrixiter, &matrixiter_tp); | |||
| if (!it) return NULL; | |||
|
|
|||
| matrixiter_tp.tp_iter = PyObject_SelfIter; | |||
| matrixiter_tp.tp_getattro = PyObject_GenericGetAttr; | |||
|
|
|||
There was a problem hiding this comment.
This works on CPython and PyPy, but is not really supported in general. All assignments are meant to be done before calling PyType_Ready
|
Thanks for investigating & fixing this! @martinandersen |
|
Yes, I'll prepare a patch release tomorrow |
Awesome, thanks! |
sanurielf
pushed a commit
to sanurielf/kvxopt
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref conda-forge/cvxopt-feedstock#45
It turns out
spmatrixiter_tpandmatrixiter_tpnever calledPyType_Ready. They also modified pointers to functions on new instances, which is not officially supported by the C-API. This caused segfaults when using cvxopt on PyPy.