-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update consensus to develop #8870
Conversation
This is a generated field, so it makes no sense to write to it. In practice, attempting to do so when creating a project causes a crash in `ProjectWriteSerializer.create`, while doing it when updating a project has no effect.
Update develop after v2.20.0
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Currently several permission classes dynamically determine scopes for `PATCH` endpoints, depending on request body fields. This is error-prone for a couple of reasons: * If you forget to add a default scope like `Scopes.VIEW`, then anyone can view the resource by submitting a `PATCH` request with an empty body. * If you add a field to a resource, but forget to define which scope it should be associated with, then anyone can modify this field on any instance of this resource. Both of these have happened previously; see <GHSA-gxhm-hg65-5gh2>. Attempt to harden the scope determination logic for such endpoints, so that such errors could not occur. Specifically: * Factor out the common logic (including the default scope) into a function. * Instead of checking for each known field in the request body, check every field in the body against a map of known fields, and abort if the field does not map to any scopes. A side effect of this change is that request bodies that set certain fields (such as `owner_id`) to the values they already have did not previously require the appropriate `UPDATE_*` scope, but now they do. This is for simplicity of implementation. I see no need to preserve the current behavior, since a user who does not have the requisite permission can simply omit the field from the request. Another side effect is that request bodies with unknown fields are now rejected, whereas previously such fields would be ignored. I think that's probably a good thing, since we can't properly fulfill such a request anyway - can't set a field that doesn't exist. This change detected a broken test in the unit test suite, so fix that.
<!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> Supporting YOLOv8 classification format ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [ ] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added support for the "YOLOv8 Classification" format in the application, including export and import functionalities. - Updated documentation to include details about the new YOLOv8 Classification format. - **Bug Fixes** - Enhanced test coverage for the new YOLOv8 Classification format to ensure proper functionality in export and import processes. - **Documentation** - Integrated new entries in the README and detailed documentation for the YOLOv8 Classification format. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
### Motivation and context fix #4767 my docker-compose.https.yml: ```yaml # Copyright (C) 2018-2022 Intel Corporation # # SPDX-License-Identifier: MIT ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [x] I have updated the documentation accordingly - [x] I have added tests to cover my changes - [x] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [x] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced comprehensive documentation for implementing custom SSL certificates in the CVAT environment. - Provided step-by-step instructions for setting up and configuring Traefik to use custom certificates. - **Documentation** - Added a new file detailing the process of creating a certificates directory, modifying Traefik configuration, and starting CVAT with custom SSL certificates. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
- Allowed quality report computation for tasks to regular users (before this only admins could trigger custom report computations) - Refactored quality control tests --------- Co-authored-by: Maria Khrustaleva <maria@cvat.ai>
Update develop after v2.21.0
<!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> The pr adds shortcuts to actions in brush tool panel (in mask editing mode) ![image](https://github.com/user-attachments/assets/a2559e58-250c-4726-a057-7ebe09f2050a) ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [x] I have added tests to cover my changes - ~~[ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~ - [x] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced keyboard shortcuts for various brush tools, enhancing user efficiency. - Added tooltips displaying keyboard shortcuts for better usability. - Implemented a `LabelSelector` component for improved label selection. - **Improvements** - Updated sorting logic for shortcut settings to organize items by their defined weights. - **Refactor** - Enhanced state management and control flow for brush tool interactions. - Added a new optional `weight` property to the key mapping interface for better customization. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
… and step (#8551) To address the identified issue, we likely need to store relative frame numbers in self._required_frames. Explanation: The only place where self._required_frames is used is in the method: ``` def _is_frame_required(self, frame): return self._required_frames is None or frame in self._required_frames ``` This method is called in: ``` def get_included_frames(self): return set( i for i in self.rel_range if not self._is_frame_deleted(i) and not self._is_frame_excluded(i) and self._is_frame_required(i) ) ``` Currently, the implementation tries to check whether a relative frame number exists in a set that contains absolute frame numbers, which doesn't work if start_frame or frame_step is defined when the task is created. This causes failures in both quality reports and immediate feedback, as well as possibly other functionalities that rely on get_included_frames. Another issue with the current code is a logical inconsistency: ``` abs_range = self.abs_range self._required_frames = set( self.abs_frame_id(frame) for frame in self._required_frames if frame in abs_range ) ``` Here, abs_frame_id expects a relative frame number and converts it to an absolute frame number, but we first check if the relative frame number from self._required_frames is already in the absolute range, which is incorrect.
…8555) <!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved video processing stability by disabling threading in video reading classes, addressing potential memory management issues. - **New Features** - Enhanced video handling capabilities with updated threading parameters for better performance during video processing. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Update develop after v2.24.0
This is a continuation of #8626.
These are currently duplicated all over the codebase, often with mismatched constraints. Put them all in one requirements file instead. Fix a few minor issues while I'm at it: * Constrain black to the current major version to avoid New Year surprises (black can change styles between major versions). Constrain isort too, just in case. * Remove usages of `egrep`, which is deprecated (and unnecessary here).
This concludes the series started in #8626.
It was only used in the Enterprise version, so I moved it there.
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
Motivation and context
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.