Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed frame initialization for base collection action #8814

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Fixed frame initialization for base collection action #8814

merged 4 commits into from
Dec 12, 2024

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Dec 11, 2024 •
edited by coderabbitai bot
Loading

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Enhanced AnnotationsActionsModalContent for improved handling of annotation actions.
    • Introduced a function to open the annotation actions modal with specified object state.

  • Improvements

    • Updated UI rendering logic for better responsiveness based on current state.
    • Enhanced handling of action parameters, supporting various input types and default values.

  • Bug Fixes

    • Improved state management for active actions and parameters, ensuring accurate updates.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2024 •
edited
Loading

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes in the pull request enhance the AnnotationsActionsModalContent component within the annotations-actions-modal.tsx file. Modifications include improved reducer logic for handling annotation actions, specifically the SET_ANNOTATIONS_ACTIONS and SET_ACTIVE_ANNOTATIONS_ACTION actions, which now incorporate frame state initialization. The ActionParameterComponent has been updated to better manage various parameter types, and the modal's rendering logic has been refined for improved UI responsiveness. Additionally, a new function, openAnnotationsActionModal, has been introduced to facilitate modal operations.

Changes

File Path Change Summary
cvat-ui/src/components/annotation-page/annotations-actions/annotations-actions-modal.tsx - Enhanced reducer logic for SET_ANNOTATIONS_ACTIONS and SET_ACTIVE_ANNOTATIONS_ACTION actions.
- Initialized frameFrom and frameTo states for BaseCollectionAction.
- Improved ActionParameterComponent to handle various parameter types.
- Adjusted modal rendering logic for better UI response.
- Added function openAnnotationsActionModal(objectState?: ObjectState).

Poem

In a modal bright with actions anew,
The frames align, and the states renew.
With parameters dancing, both bold and spry,
Annotations leap, as we reach for the sky!
A rabbit's cheer for the code's fine tune,
Hops through the fields, beneath the moon! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c0f3b31 and 823dab5.

📒 Files selected for processing (1)
  • cvat-ui/src/components/annotation-page/annotations-actions/annotations-actions-modal.tsx (2 hunks)
🔇 Additional comments (1)
cvat-ui/src/components/annotation-page/annotations-actions/annotations-actions-modal.tsx (1)

Line range hint 117-122: Actions correctly filtered based on target object state

The filtering logic correctly ensures that only applicable actions are listed when a targetObjectState is present.

cvat-ui/src/components/annotation-page/annotations-actions/annotations-actions-modal.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.89%. Comparing base (3f44834) to head (b79e731).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8814      +/-   ##
===========================================
- Coverage    73.90%   73.89%   -0.01%     
===========================================
  Files          408      408              
  Lines        43889    43887       -2     
  Branches      3986     3986              
===========================================
- Hits         32435    32431       -4     
- Misses       11454    11456       +2
Components Coverage Δ
cvat-ui 78.33% <ø> (-0.02%) ⬇️
cvat-server 70.08% <ø> (ø)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bsekachev bsekachev merged commit 18c86ff into develop Dec 12, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsekachev @codecov-commenter