Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change borken link to logo in invitation email #8438

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Change borken link to logo in invitation email #8438

merged 2 commits into from
Sep 16, 2024

Conversation

rragundez
Copy link
Contributor

@rragundez rragundez commented Sep 11, 2024 •
edited
Loading

Current link to logo in the email is broken. I used the link from the CVAT.ai page to the logo SVG image, I think this link to the SVG is autogenerated so it might change in a later deployment of CVAT.ai but I couldn't find the source of that file such that I could refer to it. If you point me to it I will change an test it.

This is how the logo looks like now:

image

this is how it was looking before:

image

Summary by CodeRabbit

  • New Features
    • Updated the invitation message with a new SVG logo for improved visual presentation.
    • Enhanced logo adaptability with responsive sizing and color inversion filter.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024 •
edited
Loading

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes involve updating the HTML template for the invitation message in the CVAT application. The logo image has been replaced with a new SVG logo from a different CDN, featuring a width of 25% and an inverted color filter. The structure of the HTML remains unchanged, maintaining the anchor tag that links to the CVAT website.

Changes

Files Change Summary
cvat/apps/organizations/templates/invitation/... Updated logo image from PNG to SVG, modified width, and added color filter.

Poem

🐰 In the meadow where logos play,
A new SVG hops in today!
With colors bright and margins neat,
The invitation's now a treat!
So let us cheer, with joy we say,
"Hooray for changes, hip-hip-hooray!" 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rragundez
Copy link
Contributor Author

@bsekachev Please review. with the update the invite header looks like this:
image

@bsekachev
Copy link
Member

Great, thanks for the contribution!

@bsekachev bsekachev merged commit beee177 into cvat-ai:develop Sep 16, 2024
34 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (d97bcad) to head (cb2381c).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8438      +/-   ##
===========================================
- Coverage    83.14%   83.13%   -0.02%     
===========================================
  Files          397      397              
  Lines        41891    41891              
  Branches      3879     3879              
===========================================
- Hits         34831    34826       -5     
- Misses        7060     7065       +5
Components Coverage Δ
cvat-ui 78.52% <ø> (-0.03%) ⬇️
cvat-server 87.22% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsekachev bsekachev bsekachev approved these changes

@Marishka17 Marishka17 Awaiting requested review from Marishka17 Marishka17 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rragundez @bsekachev @codecov-commenter