Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only store Object rotated state in updated array #8129

Merged
merged 4 commits into from
Jul 24, 2024
Merged

only store Object rotated state in updated array #8129

merged 4 commits into from
Jul 24, 2024

Conversation

KrishavRajSingh
Copy link
Contributor

@KrishavRajSingh KrishavRajSingh commented Jul 6, 2024 •
edited
Loading

fixes #8013
While rotating the rectangle, two states were stored in array, one Object Rotated and the other Changed Points. So, I just added a check that if the object is rotated, there is no need to change points.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • Enhancements
    • Improved handling of shape updates to account for rotation.
    • Reformatted method call parameters in MaskShape for better readability.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 6, 2024 •
edited
Loading

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes improve conditional logic within the Shape and MaskShape classes in annotations-objects.ts. In the Shape class, the update mechanism now properly handles cases where shapes are rotated with an added rotation check. The MaskShape class' code has been reformatted for better readability without altering functionality.

Changes

File Change Summary
cvat-core/src/annotations-objects.ts - Added a rotation check in Shape class update method
- Reformatted method call parameters in MaskShape class

Sequence Diagram(s)

No sequence diagrams generated due to the simplicity and minor nature of the changes.

Assessment against linked issues

Objective Addressed Explanation
Condition check enhancement when shape rotation is involved (#8013) ✅

Poem

In code's bright and vivid hues,
Shapes now rotate without the blues,
Condition checks, pristine and true,
Mask call tweaks, aligned anew.
Hoppy coding, changes the muse! 🚀🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 6, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c9f1cff and e7714c4.

Files selected for processing (1)
  • cvat-core/src/annotations-objects.ts (2 hunks)
Additional comments not posted (2)
cvat-core/src/annotations-objects.ts (2)

2352-2361: Formatting changes improve readability.

The formatting changes to method call parameters enhance readability and maintainability of the code.

769-769: LGTM! But verify the function usage in the codebase.

The code change ensures that points are only saved if there is no rotation, preventing redundant state storage. This aligns with the PR objective.

However, ensure that all function calls to save match the new logic.

@KrishavRajSingh KrishavRajSingh requested a review from nmanovic as a code owner July 6, 2024 19:02
@bsekachev
Copy link
Member

Hello,

Firstly, the same problem exists also for tracks as you only made a fix in Shape class, but not in Track.

Second thing is that I believe the problem is not in cvat-core. In one action user may update only points or rotation, but not both. However the function onCanvasEditDone in canvas-wrapper modifies both fields. I will recommend you to look at this.

@KrishavRajSingh
Copy link
Contributor Author

Hello,

Firstly, the same problem exists also for tracks as you only made a fix in Shape class, but not in Track.

Second thing is that I believe the problem is not in cvat-core. In one action user may update only points or rotation, but not both. However the function onCanvasEditDone in canvas-wrapper modifies both fields. I will recommend you to look at this.

You may review this

@bsekachev bsekachev merged commit d301b7d into cvat-ai:develop Jul 24, 2024
32 checks passed
@cvat-bot cvat-bot bot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@bsekachev bsekachev bsekachev approved these changes

@nmanovic nmanovic Awaiting requested review from nmanovic nmanovic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When default rotation is 0，can't exec update
2 participants
@KrishavRajSingh @bsekachev