Fixed some issues found by code scanning tool #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azhavoro
force-pushed
the
az/fix_linter
branch
from
6563779 to
4e2727f
Compare
nmanovic
reviewed
Oct 13, 2020
| @@ -112,8 +112,8 @@ def intersection_over_union(box_1, box_2): | |||
|
|
|||
| class ModelHandler: | |||
| def __init__(self, labels): | |||
| base_dir = os.environ.get("MODEL_PATH", | |||
| "/opt/nuclio/open_model_zoo/public/yolo-v3-tf/FP32") | |||
| base_dir = os.path.abspath(os.environ.get("MODEL_PATH", | |||
There was a problem hiding this comment.
Which problem does it solve?
There was a problem hiding this comment.
It solves path traversal warning
zhiltsov-max
approved these changes
Oct 13, 2020
nmanovic
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some linter issues
Motivation and context
How has this been tested?
Manually tested
Checklist
developbranch[ ] I have added description of my changes into CHANGELOG file[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (read github docs)[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.