nicknames, metric parameters, empty inputs, and memory leaks #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also now support for #12 |
… wrapper around cpp module which converts alternative formats to trec_eval format.
|
hmmm, gotta look into the failing build. |
1) Fixed issue with empty qrels on some platforms 2) Exposed the values nicknames expand to and moved logic to wrapper 3) Some cleanupq
seanmacavaney
changed the title
cvangysel
approved these changes
Mar 2, 2020
|
done |
|
Thanks @seanmacavaney! I want to take another closer look at this later, before pushing out a new release to PyPi. However, I'll merge this now so that it's installable by pointing pip to the repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.