JUnitFormatter: use ascending numbering of outline scenarios #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the JUnitFormatter use descending numbering in the names of the instantiated scenarios from scenario outlines, which seems a little unnatural. Because the JUnitFormatter relies on calls to the examples method to determine the number of instantiated scenarios, the numbering is not applied at all when using the JUnit runner. Change the JUnitFormatter to use ascending numbering, and make it work also with the JUnit runner.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the JUnitFormatter use descending numbering in the names of the instantiated scenarios from scenario outlines, which seems a little unnatural. That is (the name attribute of the testcase xml element):
Because the JUnitFormatter relies on calls to the examples method to determine the number of instantiated scenarios, the numbering is not applied at all when using the JUnit runner, then all testcase element instantiated from the scenario outline will have the value in the name attribute.
Change theJUnitFormatter to use ascending numbering, and make it work also with the JUnit runner. Basically:
Also take into account that the scenario name may contain outline argument which are replaced with values from the examples tables. That means only apply numbering of the consecutive instantiated scenario names are the same.