Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect number in the Eclipse junit summary #276

Closed
weejulius opened this issue Mar 27, 2012 · 10 comments
Closed

Incorrect number in the Eclipse junit summary #276

weejulius opened this issue Mar 27, 2012 · 10 comments

Comments

@weejulius
Copy link

Hi,

I have a feature which includes background segment, and as a result the result summary of feature is not correct.

The result should be Runs: 35/35 however what we see is Runs:35/29 and the missed 6 background scenarios go to the Unrooted Tests.

The version is 1.0.0.RC24 and the junit xml is

<?xml version="1.0" encoding="UTF-8"?>
<testrun tests="29" started="35" failures="0" errors="0" ignored="0">
  <testsuite  time="1.123">
    <testsuite name="Feature: crop images" time="1.123">
      <testsuite name="Scenario: crop jpeg" time="0.802">
       ...
      </testsuite>
      <testsuite name="Scenario: invalid parameters" time="0.197">
       ...
      </testsuite>
      <testsuite name="Scenario: crop png" time="0.1">
        ...
      </testsuite>
    </testsuite>
  </testsuite>
  <testsuite name="Unrooted Tests" time="0.131">
   ...
  </testsuite>
</testrun>
@aslakhellesoy
Copy link
Contributor

You are not saying what version you are using, and your code is unreadable. Please use GFM

I will reopen when you have fixed those 2 problems.

@weejulius
Copy link
Author

Please reopen it. I have fixed the problems
Also I can reproduce it in the version 1.0.0, you can reproduce if you have background in the feature

@aslakhellesoy
Copy link
Contributor

Looks like the bug you are mentioning was fixed in 1.0.0. How does that work for you?

https://github.com/cucumber/cucumber-jvm/blob/master/History.md

@weejulius
Copy link
Author

The issue only happens when there is background in the feature, and it is not resolved using the 1.0.0 as I test

@aslakhellesoy aslakhellesoy reopened this Mar 27, 2012
@aslakhellesoy
Copy link
Contributor

Thanks for checking. Reopening.

aslakhellesoy added a commit that referenced this issue Mar 28, 2012
@aslakhellesoy
Make sure Background steps are reported under the scenario they belon…
43ee9c8 
…g to. See #276
@aslakhellesoy
Copy link
Contributor

@weejulius can you let me know how the fix in 43ee9c8 works for you? It did fix incorrect reporting in IntelliJ, but I don't have Eclipse handy to verify.

@aslakhellesoy
Copy link
Contributor

I just tried this fix in Eclipse, and it seems to be working fine there too.

aslakhellesoy added a commit that referenced this issue Mar 29, 2012
@aslakhellesoy
Updated history for #276
a937954
@dkowis
Copy link
Member

dkowis commented Mar 29, 2012

Ah cool. I just ran into this issue today :) I'll be able to verify it in a bit.

I wonder if it's causing a different issue I'm running into, which I'm trying to isolate and debug. (will file if I find it)

@weejulius
Copy link
Author

awesome, it is fixed

Thanks

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aslakhellesoy @dkowis @weejulius