Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: slashing fix is not included #1036

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Problem: slashing fix is not included #1036

merged 6 commits into from
Mar 13, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Feb 29, 2024

Solution:

  • add the fix in a hardfork style

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang
Problem: slashing fix is not included
639258c 
Solution:
- add the fix in a hardfork style
yihuang
yihuang commented Feb 29, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang
Update CHANGELOG.md
f355ea7 
Signed-off-by: yihuang <huang@crypto.com>
yihuang
yihuang commented Feb 29, 2024
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
@yihuang
Update app/app.go
467264c 
Signed-off-by: yihuang <huang@crypto.com>
yihuang
yihuang commented Feb 29, 2024
View reviewed changes
app/forks.go Outdated Show resolved Hide resolved
@yihuang
Update app/forks.go
54a21ba 
Signed-off-by: yihuang <huang@crypto.com>
yihuang
yihuang commented Feb 29, 2024
View reviewed changes
go.mod Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 33.08%. Comparing base (641d3b9) to head (54a21ba).

❗ Current head 54a21ba differs from pull request most recent head ead1ae4. Consider uploading reports for the commit ead1ae4 to get more accurate results

Files Patch % Lines
app/forks.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##           release/v4    #1036      +/-   ##
==============================================
+ Coverage       30.08%   33.08%   +3.00%     
==============================================
  Files             125      127       +2     
  Lines           20039    20043       +4     
==============================================
+ Hits             6028     6631     +603     
+ Misses          12965    12351     -614     
- Partials         1046     1061      +15
Flag Coverage Δ
integration_tests 20.71% <33.33%> (-0.01%) ⬇️
integration_tests_byzantine 9.66% <33.33%> (-0.01%) ⬇️
integration_tests_gov 10.02% <33.33%> (-0.01%) ⬇️
integration_tests_grpc 10.00% <33.33%> (-0.01%) ⬇️
integration_tests_ibc 24.80% <33.33%> (-0.01%) ⬇️
integration_tests_ledger 9.89% <33.33%> (-0.01%) ⬇️
integration_tests_slow 9.89% <33.33%> (-0.01%) ⬇️
integration_tests_solomachine 9.69% <33.33%> (-0.01%) ⬇️
integration_tests_upgrade 10.00% <33.33%> (-0.01%) ⬇️
unit_tests 10.99% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yihuang
yihuang commented Mar 13, 2024
View reviewed changes
app/forks.go Outdated Show resolved Hide resolved
@yihuang
Update app/forks.go
c9bcc4a 
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang marked this pull request as ready for review March 13, 2024 05:06
@yihuang yihuang requested a review from a team as a code owner March 13, 2024 05:06
@yihuang yihuang merged commit 1df9b2a into crypto-org-chain:release/v4 Mar 13, 2024
24 of 25 checks passed
@yihuang yihuang deleted the release/v4 branch March 13, 2024 05:08
queenybee39
queenybee39 reviewed Aug 15, 2024
View reviewed changes
Copy link

@queenybee39 queenybee39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queenybee39 queenybee39 queenybee39 left review comments

@mmsqe mmsqe mmsqe approved these changes

@devashishdxt devashishdxt Awaiting requested review from devashishdxt

@calvinaco calvinaco Awaiting requested review from calvinaco

@lezzokafka lezzokafka Awaiting requested review from lezzokafka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @mmsqe @queenybee39