This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
gn: Implement the "xwalk_runtime_lib_lzma_apk" target #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was hopefully the last missing Android target in the gyp->GN conversion, and it is an ugly one: we are forced to keep a hardcoded list of all the files we want to compress and ship as assets, which makes the change to `runtime/android/runtime_lib/BUILD.gn` bigger than usual. Since `android_assets()` in GN requires a list of all files being shipped as assets, we can simplify `lzma_compress.py` and get rid of its different operation modes: instead of passing `--mode=show-output-names` we just list all files that are being compressed in gyp. While here, also use a temporary directory to perform the compressions in `lzma_compress.py`, as it's then removed automatically in case something goes wrong and we are not left with dangling files in the build tree. BUG=XWALK-7285
|
Testing patch series with rakuco/crosswalk@d7f43b4 as its head.
|
|
@rakuco Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was hopefully the last missing Android target in the gyp->GN
conversion, and it is an ugly one: we are forced to keep a hardcoded
list of all the files we want to compress and ship as assets, which
makes the change to
runtime/android/runtime_lib/BUILD.gnbigger thanusual.
Since
android_assets()in GN requires a list of all files beingshipped as assets, we can simplify
lzma_compress.pyand get rid of itsdifferent operation modes: instead of passing
--mode=show-output-nameswe just list all files that are being compressed in gyp.
While here, also use a temporary directory to perform the compressions
in
lzma_compress.py, as it's then removed automatically in casesomething goes wrong and we are not left with dangling files in the
build tree.
BUG=XWALK-7285