This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Directly depend on the .so's we want to strip #3909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in commit 8f3c7d3 ("[Android] Stop depending on xwalk_core_shell from xwalk_core_library"), where `libxwalkdummy.so` and `libxwalkcore.so` were not being stripped and added to `xwalk_core_library/` (which is then used for the AAR and `xwalk_app_template`) in incremental builds, leading to outdated, existing versions being used instead. The bug was caused by us not explicitly depending on both unstripped shared libraries in the action that includes `strip_native_libraries.gypi`: we were previously only depending on `native_libraries.json` being updated whenever those shared libraries changed, but `write_ordered_libraries.py` only updates the JSON file if its contents are actually different (if we started depending on other shared libraries, for example). BUG=XWALK-7335
|
Testing patch series with rakuco/crosswalk@2b7bb9e as its head.
|
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in commit 8f3c7d3 ("[Android] Stop
depending on xwalk_core_shell from xwalk_core_library"), where
libxwalkdummy.soandlibxwalkcore.sowere not being stripped andadded to
xwalk_core_library/(which is then used for the AAR andxwalk_app_template) in incremental builds, leading to outdated,existing versions being used instead.
The bug was caused by us not explicitly depending on both unstripped
shared libraries in the action that includes
strip_native_libraries.gypi: we were previously only depending onnative_libraries.jsonbeing updated whenever those shared librarieschanged, but
write_ordered_libraries.pyonly updates the JSON file ifits contents are actually different (if we started depending on other
shared libraries, for example).
BUG=XWALK-7335