makefile: integrate xpkg publishing process #142
Conversation
…Upbound marketplace, too Signed-off-by: Muvaffak Onus <me@muvaf.com>
Signed-off-by: Muvaffak Onus <me@muvaf.com>
There was a problem hiding this comment.
@muvaf thanks for updating this! We are going to need some more changes for it to work fully. crossplane-contrib/provider-aws#1460 may be useful to model after
…ller binary Signed-off-by: Muvaffak Onus <me@muvaf.com>
|
The integration test fails with the following event on @hasheddan @turkenh does this ring a bell? It works as expected when I run the controller locally with |
|
Alright the problem turned out to be that distroless image didn't allow Helm to call Another thing is that bitnami wordpress image does not yet support ARM apparently bitnami/charts#7305 |
Makefile
Outdated
| @@ -2,7 +2,6 @@ | |||
| PROJECT_NAME := provider-helm | |||
| PROJECT_REPO := github.com/crossplane-contrib/$(PROJECT_NAME) | |||
|
|
|||
| PLATFORMS ?= linux_amd64 linux_arm64 | |||
There was a problem hiding this comment.
@muvaf does this need to be dropped?
There was a problem hiding this comment.
I didn't see it in provider-aws and thought we probably don't need it here either. Is there a reason to keep it? The default in submodule seems to include darwin and windows as well.
There was a problem hiding this comment.
I believe that it is present in all providers (example in provider-aws). The only issue it would cause is in image construction, but it looks like it is being skipped correctly. I think building the extra binaries here is not really needed, but I'm not strongly against it.
There was a problem hiding this comment.
Oh I missed that. I'd prefer not to deviate, reverted that part. Thanks!
try to create /.cache folder which is not allowed in distroless. Signed-off-by: Muvaffak Onus <me@muvaf.com>
muvaf
force-pushed
the
integrate-xpkg
branch
from
eb369de to
61456ad
Compare
|
Successfully created backport PR #143 for |
Description of your changes
This adds the consumption of
xpkgbuild lib so that we push XPKG to Upbound marketplace. It needsXPKG_ACCESS_IDandXPKG_TOKENsecret vars that can push toxpkg.upbound.io/crossplanebut I don't have access to that org @hasheddanI borrowed most of the logic from https://github.com/crossplane-contrib/provider-aws/blob/master/Makefile
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
make -j2 build.alland see a multi-arch xpkg is built.e2e-testtarget of the PR.