fix(dbinstance): in isUpToDate consider 0 and nil to be equal for iops/storageThroughput #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torageThroughput Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <charel.baum-extern@deutschebahn.com>
|
Successfully created backport PR #2040 for |
wotolom
deleted the
rds-dbinstance-iops-storagethroughput-isuptodate-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
AWS seems to be giving different responses for IOPS/StorageThroughput (either 0 or nil) depending on whether the instance was created as
gp2or modified from another storageType (e.g.gp3) togp2,This changes their
isUptoDate()checks to consider both 0 and nil to be equivalent.Also I used the opportunity and added missing parameters to the built diff for the logs.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
manually