feat(Compositions): drop spec.environmentConfigRefs #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phisco
force-pushed
the
more-env-cleanup
branch
from
47678d0 to
4661259
Compare
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
phisco
force-pushed
the
more-env-cleanup
branch
from
4661259 to
88e5a25
Compare
negz
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We forgot to drop Composition's
spec.environmentConfigRefsas part of #5938.I have:
Added or updated unit tests.Added or updated e2e tests.Linked a PR or a tracking issue to document this change.kind:[type]label on the PR.Added release notes if required.Addedbackport release-x.ylabels to auto-backport this PR, as appropriate.Need help with this checklist? See the cheat sheet.