Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some pictures to the README #1

Closed
wants to merge 2 commits into from
Closed

Conversation

MangoIV
Copy link

@MangoIV MangoIV commented Dec 17, 2021

Hi! Someone from a server I'm on complained about Repos not having pictures in their readme, so here we go, I'm doing my part. :)

(cool board by the way)

some guy from the discord server complained there weren't any pictures in the readme so I added them.
@crides
Copy link
Owner

crides commented Dec 17, 2021

I expected the list to be long, so all board pics are in versions.md, and I hope the link to that is obvious enough. If people find it not to be the case, is there something you would suggest?

@MangoIV
Copy link
Author

MangoIV commented Dec 17, 2021

Well, of course it's your decision but I think there are so many keyboards out there, sometimes you just don't wanna take the time and go through all the files in the repo to find how it looks.
I also always just put the pics at the end of the README so they're reasonably easy to find and still don't take up the space of the more important info ;)

@crides
Copy link
Owner

crides commented Dec 17, 2021

I certainly don't expect people to go through all the files, that's why it's linked in the README, and I was asking if there's anything that could be done to make the link more obvious

Alternatively, I could just put the picture of the latest version at the end of the README.

@MangoIV
Copy link
Author

MangoIV commented Dec 17, 2021

I think the latter is a good compromise. Sorry, that probably took more of the time of you than it should have :D

@crides crides closed this in 0dcf934 Dec 17, 2021
@crides
Copy link
Owner

crides commented Dec 17, 2021

No problem. I need other people to criticize my work :).

Also the latest is v3.2. I have a habit of not documenting things until after I switched to a new version

crides added a commit that referenced this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants