Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NRI to v0.9.0 #8855

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Update NRI to v0.9.0 #8855

merged 1 commit into from
Dec 17, 2024

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support NRI v0.9.0.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Updated NRI to v0.9.0.

@saschagrunert saschagrunert added this to the 1.32 milestone Dec 16, 2024
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 16, 2024
@openshift-ci openshift-ci bot requested review from klihub and QiWang19 December 16, 2024 09:50
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@saschagrunert saschagrunert mentioned this pull request Dec 16, 2024
Closed
@kwilczynski
Copy link
Member

/approve

@saschagrunert
Update NRI to v0.9.0
10621f0 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.95%. Comparing base (d8220db) to head (10621f0).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8855      +/-   ##
==========================================
- Coverage   47.00%   46.95%   -0.06%     
==========================================
  Files         154      154              
  Lines       21978    21978              
==========================================
- Hits        10331    10320      -11     
- Misses      10587    10599      +12     
+ Partials     1060     1059       -1

@saschagrunert
Copy link
Member Author

/test ci-crun-e2e

sohankunkerkar
sohankunkerkar approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kwilczynski,saschagrunert,sohankunkerkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member Author

/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-aws-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-aws-ovn, ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 8564f35 into cri-o:main Dec 17, 2024
65 of 70 checks passed
@saschagrunert saschagrunert deleted the nri branch December 17, 2024 08:10
@saschagrunert saschagrunert mentioned this pull request Dec 18, 2024
Open
@github-actions github-actions bot mentioned this pull request Dec 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@kwilczynski kwilczynski

@sohankunkerkar sohankunkerkar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @kwilczynski @sohankunkerkar