Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go 1.23 for nix (static) builds #8598

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Use go 1.23 for nix (static) builds #8598

merged 1 commit into from
Sep 13, 2024

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

Build static binaries using the latest go.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Use go 1.23 for nix (static) builds.

@saschagrunert
Use go 1.23 for nix (static) builds
3335302 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/ci Categorizes issue or PR as related to CI dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 12, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.86%. Comparing base (b7cc915) to head (3335302).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8598      +/-   ##
==========================================
- Coverage   48.88%   48.86%   -0.02%     
==========================================
  Files         153      153              
  Lines       17372    17372              
==========================================
- Hits         8492     8489       -3     
- Misses       7815     7817       +2     
- Partials     1065     1066       +1

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-rhel-critest

unrelated.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-rhel-critest

In response to this:

/override ci/prow/ci-rhel-critest

unrelated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-e2e-evented-pleg

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg

In response to this:

/override ci/prow/ci-e2e-evented-pleg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-rhel-critest
/override ci/prow/ci-cgroupv2-e2e-crun
/override ci/prow/ci-cgroupv2-integration
/override ci/prow/images

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 13, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-e2e-crun, ci/prow/ci-cgroupv2-integration, ci/prow/ci-rhel-critest, ci/prow/images

In response to this:

/override ci/prow/ci-rhel-critest
/override ci/prow/ci-cgroupv2-e2e-crun
/override ci/prow/ci-cgroupv2-integration
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 548e070 into cri-o:main Sep 13, 2024
81 of 82 checks passed
@saschagrunert saschagrunert deleted the nix-go-1.23 branch September 13, 2024 07:11
@github-actions github-actions bot mentioned this pull request Dec 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@kwilczynski kwilczynski Awaiting requested review from kwilczynski

Assignees

@kwilczynski kwilczynski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschagrunert @kwilczynski