Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an endpoint for heap dumps #7307

Closed
sohankunkerkar opened this issue Sep 14, 2023 · 16 comments · Fixed by #8702
Closed

Add an endpoint for heap dumps #7307

sohankunkerkar opened this issue Sep 14, 2023 · 16 comments · Fixed by #8702
Assignees
@saschagrunert
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sohankunkerkar
Copy link
Member

What happened?

This issue aims to add an endpoint for heap dumps in CRI-O, which can be a valuable debugging and diagnostics feature. You can get help from the existing WIP PR.

What did you expect to happen?

N/A

How can we reproduce it (as minimally and precisely as possible)?

N/A

Anything else we need to know?

#5197

CRI-O and Kubernetes version

$ crio --version
# paste output here
$ kubectl version --output=json
# paste output here

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

Additional environment details (AWS, VirtualBox, physical, etc.)
@sohankunkerkar sohankunkerkar added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Sep 14, 2023
@sohankunkerkar sohankunkerkar mentioned this issue Sep 14, 2023
Closed
@MeenuyD
Copy link

MeenuyD commented Sep 15, 2023

Hello, I am ready to create PR but I do not understand this Idea: Add a subcommand to crio-status to dump to a specific file location. can you explain

@saschagrunert saschagrunert moved this to Backlog in Feature Roadmap Sep 15, 2023
@sohankunkerkar
Copy link
Member Author

We are planning to deprecate the crio-status command in 1.29, so my ideal bet is to add a command line flag to crio.
@saschagrunert wdyt?

@saschagrunert
Copy link
Member

@sohankunkerkar sounds good to me!

@sohankunkerkar
Copy link
Member Author

sohankunkerkar commented Sep 18, 2023 •
edited
Loading

Alright, @MeenuyD, the idea is to add a command line argument called --enable-heap-dump. When the user sets that flag, CRI-O will generate a file at the specified location containing heap dump information. Let's add that option here: https://github.com/cri-o/cri-o/blob/main/pkg/config/config.go#L237. You can see this example PR to get more information.

@sohankunkerkar
Copy link
Member Author

@MeenuyD do you want to pursue the changes?

@hernandanielg
Copy link

hey @sohankunkerkar I want to contribute with this if you allow me :) (I'll need some help tho)

@hernandanielg hernandanielg mentioned this issue Sep 22, 2023
Closed
@kwilczynski kwilczynski moved this from Backlog to In Progress in Feature Roadmap Sep 26, 2023
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 28, 2023
@shipra101
Copy link

I would like to work on this if no one is on it

@kwilczynski
Copy link
Member

@shipra101, a person is already assigned, and @hernandanielg might still be working on it.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2023
@github-actions GitHub Actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2024
@sohankunkerkar sohankunkerkar removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 18, 2024
@github-actions GitHub Actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2024
@saschagrunert saschagrunert added kind/feature Categorizes issue or PR as related to a new feature. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 7, 2024
@saschagrunert
Copy link
Member

@shipra101 @hernandanielg are you still considering to work on this?

@saschagrunert saschagrunert moved this from In Progress to To do in Feature Roadmap May 7, 2024
@hernandanielg
Copy link

I waited for the decision on this, I thought it wasn't required anymore 🤷🏻
#7328 (comment)

I can re-open that PR and give it a try for sure, just let me know how to proceed

Thanks! 🙇🏻

@saschagrunert
Copy link
Member

@cri-o/cri-o-maintainers how do we want to proceed with this?

@sohankunkerkar
Copy link
Member Author

I think we need some consensus on #7615

@kwilczynski kwilczynski mentioned this issue Oct 22, 2024
Merged
@saschagrunert saschagrunert mentioned this issue Oct 23, 2024
Merged
@saschagrunert saschagrunert removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 23, 2024
@saschagrunert saschagrunert moved this from To do to In Progress in Feature Roadmap Oct 23, 2024
@saschagrunert
Copy link
Member

Working on this as part of #8702

@github-project-automation github-project-automation bot moved this from In Progress to Done in Feature Roadmap Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saschagrunert saschagrunert

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Feature Roadmap
Archived in project
Milestone
No milestone
6 participants
@kwilczynski @saschagrunert @hernandanielg @sohankunkerkar @shipra101 @MeenuyD