Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libseccomp is required for compilation #218

Closed
Crazykev opened this issue Nov 29, 2016 · 1 comment · Fixed by #8686
Closed

libseccomp is required for compilation #218

Crazykev opened this issue Nov 29, 2016 · 1 comment · Fixed by #8686

Comments

@Crazykev
Copy link
Contributor

If don't have libseccomp package locally, will have a compile error.
Maybe need a update to README to add hint of install libseccomp package since we have supported.
@runcom
Copy link
Member

runcom commented Nov 29, 2016

@Crazykev thanks, will do.

@runcom runcom mentioned this issue Nov 29, 2016
Merged
egernst pushed a commit to egernst/cri-o that referenced this issue Nov 26, 2018
@jcvenegas
Merge pull request cri-o#218 from nitkon/qemu
3ff5b41 
qemu-vanilla: Make spec-template file requirement arch-specific
michalsieron added a commit to michalsieron/cri-o that referenced this issue Oct 16, 2024
@michalsieron
Re-allow building without seccomp installed
8719b90 
I think cri-o#3300 regressed cri-o#218 by unconditionally compiling with seccomp
enabled. cri-o#6488 fixed this for non-linux and non-cgo build platforms, but
the issue still exists when one uses a cgo-enabled Linux build host
but still wants to build without seccomp. In such case build ends quickly
with pkg-config error: `Package 'libseccomp' not found`.

This patch makes internal/config/seccomp respect the seccomp buildtag.

Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
@michalsieron michalsieron mentioned this issue Oct 16, 2024
Merged
michalsieron added a commit to michalsieron/cri-o that referenced this issue Oct 16, 2024
@michalsieron
Re-allow building without seccomp installed
7849e3e 
I think cri-o#3300 regressed cri-o#218 by unconditionally compiling with seccomp
enabled. cri-o#6488 fixed this for non-linux and non-cgo build platforms, but
the issue still exists when one uses a cgo-enabled Linux build host
but still wants to build without seccomp. In such case build ends quickly
with pkg-config error: `Package 'libseccomp' not found`.

This patch makes internal/config/seccomp respect the seccomp buildtag.

Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
xw19 pushed a commit to xw19/cri-o that referenced this issue Dec 4, 2024
@michalsieron @xw19
Re-allow building without seccomp installed
7aa784c 
I think cri-o#3300 regressed cri-o#218 by unconditionally compiling with seccomp
enabled. cri-o#6488 fixed this for non-linux and non-cgo build platforms, but
the issue still exists when one uses a cgo-enabled Linux build host
but still wants to build without seccomp. In such case build ends quickly
with pkg-config error: `Package 'libseccomp' not found`.

This patch makes internal/config/seccomp respect the seccomp buildtag.

Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-allow building without seccomp installed michalsieron/cri-o
2 participants
@runcom @Crazykev