Enable the load extension API #39
Conversation
Expose the C API version of the enable load extension functionality. The SQL version is not enabled when calling EnableLoadExtension().
Add a function that attempts to visit all connections in a Pool. Allows for a timeout, same as Get() and others.
extension.go
Outdated
| cext := C.CString(ext) | ||
| defer C.free(unsafe.Pointer(cext)) | ||
| var centry *C.char | ||
| centry = nil |
|
Whoops, All snuck in somewhere, I'll send a new request. |
|
Sorry for the messy PR... |
extension_test.go
Outdated
|
|
||
| const ( | ||
| extCode = ` | ||
| /* |
There was a problem hiding this comment.
you can skip the copyright notice in a temporary file.
There was a problem hiding this comment.
Yes, of course...
| sqlite3_context *context, | ||
| int argc, | ||
| sqlite3_value **argv){ | ||
| (void)argc; |
There was a problem hiding this comment.
interesting style. is there a particular linter or guide you are working to?
There was a problem hiding this comment.
No, I started from the example on https://www.sqlite.org/loadext.html#write, and went from there. SQLite's style is similar, I substituted tabs for spaces.
extension_test.go
Outdated
| defer func() { | ||
| err := c.Close() | ||
| if err != nil { | ||
| t.Error(nil) |
extension_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
| io.Copy(fout, strings.NewReader(extCode)) | ||
| fout.Close() |
There was a problem hiding this comment.
as you are writing a file, check the error here and on the copy.
as that gets tedious, use ioutile:
if err := ioutile.WriteFile(file path.Join(tmpdir, "ext.c")), []byte(extCode), 0666); err != nil {
...
}
|
Thanks for the feedback, I'll make the final changes when I get a chance. |
|
As a side note, I added this so I could load the spatialite extension, but it seems Dr. Hipp is added base functionality as a new extension: https://sqlite.org/src/timeline?r=rtree-geopoly&nd&c=2018-08-23+14%3A54%3A45&n=200 I'm always amazed at the quality of SQLite. |
Allow enabling the load extension mechanism and actually loading extensions. This enables the C API only, not the SQL API.