Fix crash in Xom's wave of despair effect #4037
Conversation
If place_monster_corpse returns nullptr, the game crashes when trying to call turn_corpse_into_skeleton. Possible when placing a skeleton on a terrain feature that destroys items, like lava. (move_item_to_grid destroys the would-be corpse item) Example crash log: https://underhound.eu/crawl/morgue/seandewar5/crash-seandewar5-20240902-225318.txt
|
(...Sorry your name isn't on the commit- I was trying out Github's PR merging options and didn't realize that it'd override the author after auto-wrapping the crash log url unless I specified otherwise. Thank you for submitting this PR and fixing the bug.) |
|
Thanks and no problem! Seems it was added via a merge commit, which references the commit from my branch as a parent anyway. 👍 If that wasn't desired, GitHub's "squash and merge" feature may be useful: it combines all commits into one, keeping author metadata, and merges it without creating the extra merge commit; you'll have the option of editing its message too, but by default GitHub appends the PR number at the end of the first line. (There's also "rebase and merge" if squashing isn't wanted, but I can't recall if you're given the option to edit the messages or not when there's more than one commit) |
If
place_monster_corpsereturns nullptr, the game crashes when trying to callturn_corpse_into_skeleton.Possible when placing a skeleton on a terrain feature that destroys items, like lava. (
move_item_to_griddestroys the would-be corpse item)Example crash log: https://underhound.eu/crawl/morgue/seandewar5/crash-seandewar5-20240902-225318.txt