Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash closing property page launched from filters window #329

Closed
mikecopperwhite opened this issue Mar 5, 2019 · 1 comment
Closed

Crash closing property page launched from filters window #329

mikecopperwhite opened this issue Mar 5, 2019 · 1 comment

Comments

@mikecopperwhite
Copy link
Collaborator

STEPS
Launch application
Graph Insert Filter
Select Filter (e.g. AVI Mux)
Click Property Page
Click Close on launched property page

EXPECTED
Property page closes

ACTUAL
Application crashes

Side effect of the fix for issue #239 when property page is launched without being associated with a filter.
mikecopperwhite added a commit that referenced this issue Mar 5, 2019
@mikecopperwhite
Fix for issue #329 : crash closing property page launched from filter…
71d6bb6 
…s window.
@mikecopperwhite
Copy link
Collaborator Author

Fixed by commit https://github.com/cplussharp/graph-studio-next/commit/71d6bb684b7b18bf8bc6007c07dd96a5de3385eb

Code was previously closing property pages which had null filter pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikecopperwhite