Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[health] Fix #1059: Add check flags for permissions #1069

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

iarata
Copy link
Contributor

@iarata iarata commented Oct 30, 2024

Until version 11.1.0 when there are multiple requests for permission on Android the app crashes #1059. This can be reproduced in the example app when it is running on the Samsung A546B and the Authenticate button is clicked multiple times very fast.

This PR adds a check flag to prevent sending new permission requests if one is already requested.

@iarata iarata changed the title [health] Fix #1059 [health] Fix #1059: Add check flags for permissions Oct 30, 2024
@iarata iarata added the bugfix a bug fix label Oct 30, 2024
Copy link
Contributor

@bardram bardram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iarata
Copy link
Contributor Author

iarata commented Nov 28, 2024

Closes #1059

@iarata iarata merged commit 3784963 into cph-cachet:master Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants