[Health]: Remove Google Fit support #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlimShadyIAm
force-pushed
the
feature/remove-google-fit
branch
from
a20952a to
6aa6d77
Compare
SlimShadyIAm
force-pushed
the
feature/remove-google-fit
branch
from
6aa6d77 to
3979573
Compare
|
Remember to add entry to CHANGELOG and bump version before publishing. |
|
When testing on iOS and pressing "Add Data" the app throws an uncaught exception: |
Fixed - when writing health datapoints, we weren't checking if the data type is available on the platform. The example app was trying to write Android-exclusive data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google will soon be turning down support for Google Fit in favor of Google Health Connect in the coming months, and as such we have previously planned to remove support for it in the
healthplugin.This PR includes also includes a cleanup of the Android code and updates to the documentation.
Changelog
useHealthConnectIfAvailablefrom the parameters ofHealth().configure()HealthWorkoutActivityTypes which were supported by Google Fit. Some of these do not have suitable alternatives in Google Health Connect (and are not supported on iOS). The list of removed types include:MOVE_MINUTESAEROBICSBIATHALONBIKING_HANDBIKING_MOUNTAINBIKING_ROADBIKING_SPINNINGBIKING_UTILITYCIRCUIT_TRAININGCROSS_FITDIVINGELEVATORESCALATORGARDENINGHORSEBACK_RIDINGHOUSEWORKIN_VEHICLEINTERVAL_TRAININGKAYAKINGKETTLEBELL_TRAININGKICK_SCOOTERKITE_SURFINGMEDITATIONMIXED_MARTIAL_ARTSP90XPOLORUNNING_JOGGINGRUNNING_SANDSKATING_CROSSSKATING_INDOORSKATING_INLINESKIING_BACK_COUNTRYSKIING_KITESKIING_ROLLERSLEDDINGSTANDUP_PADDLEBOARDINGSTILLTEAM_SPORTSTILTINGTREADMILLVOLLEYBALL_BEACHVOLLEYBALL_INDOORWAKEBOARDINGWALKING_FITNESSWALKING_NORDICWALKING_STROLLERWALKING_TREADMILLWINDSURFINGZUMBAOTHERworkout type on Androiddisconnectmethod which was previously used to disconnect from Google Fit.flowRatevalue fromwriteBloodOxygenas this is not supported by Health Connect.